Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/jenkins: switch to openjdk11 as openjdk14 is not supported #99541

Merged
merged 1 commit into from Oct 19, 2020
Merged

nixos/jenkins: switch to openjdk11 as openjdk14 is not supported #99541

merged 1 commit into from Oct 19, 2020

Conversation

aborsu
Copy link
Contributor

@aborsu aborsu commented Oct 4, 2020

Motivation for this change

Jenkins service failed for nixos-unstable

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Oct 19, 2020

@GrahamcOfBorg test jenkins

@Mic92 Mic92 merged commit 46bd18f into NixOS:master Oct 19, 2020
@aborsu aborsu deleted the jenkins branch November 1, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earldouglas earldouglas earldouglas approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aborsu @Mic92 @earldouglas