BUGFIX: Fix endianness issues with PIE binaries #245
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few endianness issues were encountered when setting an RPATH on ppc32 PIEs (since they are of type DYN). This pull request fixes those issues, and adds regression tests for:
The
no-rpath-pie-powerpc
was generated by compiling the foo.c bar.c and main.c in the tests directory with a ppc32 cross toolchain and-pie -fpie
arguments.Previous
readelf -l
results after patchingNew
readelf -l
results after patching