Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-edit: 0.6.0 -> 0.7.0 #99525

Merged
merged 1 commit into from Oct 4, 2020
Merged

cargo-edit: 0.6.0 -> 0.7.0 #99525

merged 1 commit into from Oct 4, 2020

Conversation

kevincox
Copy link
Contributor

@kevincox kevincox commented Oct 4, 2020

Motivation for this change

Get the sort-by-default behaviour in the new version :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kevincox kevincox self-assigned this Oct 4, 2020
@kevincox
Copy link
Contributor Author

kevincox commented Oct 4, 2020

maintiners: @Gerschtli @Gerschtli @jb55 @filalex77 @killercup

Copy link
Member

@killercup killercup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Works great here on NixOS nightly :)

@kevincox kevincox merged commit b526796 into master Oct 4, 2020
@kevincox kevincox deleted the kevincox-cargo-edit branch October 4, 2020 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants