sphinx-intl: init at 2.0.1 #99544
Closed
sphinx-intl: init at 2.0.1 #99544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvarWithoutBones
requested changes
Oct 8, 2020
|
Ivar <notifications@github.com> writes:
@IvarWithoutBones requested changes on this pull request.
Just 2 minor nits, otherwise LGTM 👍
> @@ -2705,6 +2705,10 @@
fingerprint = "67FE 98F2 8C44 CF22 1828 E12F D57E FA62 5C9A 925F";
}];
};
+ euandreh = {
This should be in a seperate commit.
👍, I'll rebase and split the commits.
> @@ -0,0 +1,27 @@
+{ lib
I don't see `lib` being used anywhere.
It's used on `with lib.maintainers;`.
|
|
I've rebased with master and split the commits.
@IvarWithoutBones could you review again?
|
|
Ivar <notifications@github.com> writes:
@IvarWithoutBones commented on this pull request.
> +buildPythonPackage rec {
+ pname = "sphinx-intl";
+ version = "2.0.1";
+
+ src = fetchPypi {
+ inherit pname version;
+ sha256 = "1d1q0sanjp4nkfvhsxi75zf3xjyyi8nzxvl3v7l0jy9ld70nwnmj";
+ };
+
+ propagatedBuildInputs = [ Babel click sphinx ];
+
+ meta = with stdenv.lib; {
+ description = "Translation support for Sphinx";
+ homepage = "https://github.com/sphinx-doc/sphinx-intl";
+ license = licenses.bsd2;
+ maintainers = with lib.maintainers; [ euandreh ];
`lib` is not required here, as its already in scope due to the `with stdenv.lib;` above.
👍
I've rebased again.
… ```suggestion
maintainers = with maintainers; [ euandreh ];
```
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#99544 (review)
|
10 tasks
SuperSandro2000
requested changes
Nov 25, 2020
|
Result of 1 package marked as broken and skipped:
2 packages built:
|
|
I've disabled for older Python versions and rebased with master.
`nixpkgs-review pr 99544` runs successfully for me now.
|
SuperSandro2000
requested changes
Nov 26, 2020
|
Sandro <notifications@github.com> writes:
# package does not contain any tests
doChecks = false;
Done and rebased with master.
|
|
BTW, thanks @SuperSandro2000 for the reviews!
|
| @@ -2765,6 +2765,10 @@ | |||
| fingerprint = "67FE 98F2 8C44 CF22 1828 E12F D57E FA62 5C9A 925F"; | |||
| }]; | |||
| }; | |||
| euandreh = { | |||
| name = "EuAndreh"; | |||
There was a problem hiding this comment.
Please add your github name and id like the entries above and below you.
Please do not rebase on master. This is only necessary if there are eval errors. Otherwise I cannot follow the changes you did that easily. |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing stale pull request. Future interested parties may pick this up and merge in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add
sphinx-intlpackage.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Execution of binary tested with:
nix-shell -I nixpkgs=. -p 'python3.withPackages (p: [ p.sphinx-intl ])' --run sphinx-intl