Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] pythonPackages.hidapi: fix build on darwin #99543

Merged
merged 1 commit into from Oct 4, 2020
Merged

[20.09] pythonPackages.hidapi: fix build on darwin #99543

merged 1 commit into from Oct 4, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Oct 4, 2020

Motivation for this change

ZHF: #97479

Backport of #99478

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
pythonPackages.hidapi: fix build on darwin
63f0d99 
also add pythonImportsCheck

(cherry picked from commit bd55969)
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 6.topic: python labels Oct 4, 2020
@ofborg ofborg bot requested a review from np October 4, 2020 11:37
r-burns
r-burns approved these changes Oct 4, 2020
View reviewed changes
Copy link
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM, some reverse dependencies still broken as expected.

macOS 10.14:

Result of nixpkgs-review pr 99543 1

14 packages marked as broken and skipped:
  • electrum
  • hwi
  • keepkey_agent
  • python37Packages.hwi
  • python37Packages.keepkey
  • python37Packages.keepkey_agent
  • python37Packages.trezor
  • python37Packages.trezor_agent
  • python38Packages.hwi
  • python38Packages.keepkey
  • python38Packages.keepkey_agent
  • python38Packages.trezor
  • python38Packages.trezor_agent
  • trezor_agent
2 packages failed to build:
  • plover.stable
  • python27Packages.ledgerblue
16 packages built:
  • cm-rgb
  • ledger_agent (python38Packages.ledger_agent)
  • python27Packages.btchip
  • python27Packages.hidapi
  • python27Packages.python-u2flib-host
  • python37Packages.btchip
  • python37Packages.ckcc-protocol
  • python37Packages.hidapi
  • python37Packages.ledger_agent
  • python37Packages.ledgerblue
  • python37Packages.python-u2flib-host
  • python38Packages.btchip
  • python38Packages.ckcc-protocol
  • python38Packages.hidapi
  • python38Packages.ledgerblue
  • python38Packages.python-u2flib-host

non-NixOS Linux:

Result of nixpkgs-review pr 99478 1

1 package failed to build:
  • python27Packages.ledgerblue
29 packages built:
  • cm-rgb
  • electron-cash
  • electrum
  • hwi (python38Packages.hwi)
  • keepkey_agent (python38Packages.keepkey_agent)
  • ledger_agent (python38Packages.ledger_agent)
  • plover.stable
  • python27Packages.btchip
  • python27Packages.hidapi
  • python27Packages.python-u2flib-host
  • python37Packages.btchip
  • python37Packages.ckcc-protocol
  • python37Packages.hidapi
  • python37Packages.hwi
  • python37Packages.keepkey
  • python37Packages.keepkey_agent
  • python37Packages.ledger_agent
  • python37Packages.ledgerblue
  • python37Packages.python-u2flib-host
  • python37Packages.trezor
  • python37Packages.trezor_agent
  • python38Packages.btchip
  • python38Packages.ckcc-protocol
  • python38Packages.hidapi
  • python38Packages.keepkey
  • python38Packages.ledgerblue
  • python38Packages.python-u2flib-host
  • python38Packages.trezor
  • trezor_agent (python38Packages.trezor_agent)

@risicle risicle merged commit b2ac083 into NixOS:release-20.09 Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-burns r-burns r-burns approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

@np np Awaiting requested review from np

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @r-burns