Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: click_helpers, logging_helpers and sentry_helpers #1

Merged
merged 1 commit into from Oct 4, 2020
Merged

Add: click_helpers, logging_helpers and sentry_helpers #1

merged 1 commit into from Oct 4, 2020

Conversation

TrueBrain
Copy link
Member

This is code that is shared between almost all OpenTTD python
projects and is meant as a deduplication step.

@glx22
Copy link

glx22 commented Oct 4, 2020

This PR seems to include #2 and #3

@TrueBrain
Copy link
Member Author

That doesn't only seem so, it is really just that. So review #2 and #3 and that gets resolved ;)

@TrueBrain
Add: click_helpers, logging_helpers and sentry_helpers
610b913 
This is code that is shared between almost all OpenTTD python
projects and is meant as a deduplication step.
glx22
glx22 approved these changes Oct 4, 2020
View reviewed changes
Copy link

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok

@TrueBrain TrueBrain merged commit d35ff57 into OpenTTD:master Oct 4, 2020
@TrueBrain TrueBrain deleted the first_version branch October 4, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glx22 glx22 glx22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TrueBrain @glx22