Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qtile: add missing python package dependencies #99538

Merged
merged 2 commits into from Oct 21, 2020
Merged

qtile: add missing python package dependencies #99538

merged 2 commits into from Oct 21, 2020

Conversation

vividn
Copy link
Contributor

@vividn vividn commented Oct 4, 2020 •
edited

Motivation for this change

Qtile cannot connect to dbus and cause applications to freeze when they attempt to send notifications.
For example, slack will completely freeze when a new message comes in after it attempts to send a notification.

This is caused by an inability to import dbus and pygobject3 as evidenced by this error in the logs
WARNING libqtile manager.py:setup_eventloop():L240 importing dbus/gobject failed, dbus will not work.

Also added the python packages dependencies mentioned here:
#45039
DavHau/mach-nix#125

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vividn
Add more python package dependencies for qtile
89e211f 
Qtile cannot connect to dbus and cause applications to freeze when they attempt to send notifications.
For example, slack will completely freeze when a new message comes in after it attempts to send a notification.

This is caused by an inability to import dbus and pygobject3 as evidenced by this error in the logs
`WARNING libqtile manager.py:setup_eventloop():L240 importing dbus/gobject failed, dbus will not work.`

Also added the python packages dependencies mentioned here:
NixOS#45039
DavHau/mach-nix#125
@ofborg ofborg bot requested a review from kamilchm October 4, 2020 09:25
@vividn vividn marked this pull request as ready for review October 4, 2020 11:35
@vividn
Copy link
Contributor Author

vividn commented Oct 5, 2020

Hey @kamilchm, this is my first PR on nixpkgs. Is there anything else I have to do here before this gets merged in?

@kamilchm
Copy link
Member

kamilchm commented Oct 5, 2020

Hi, anything we can do now is waiting for someone with merge permission, which should happen shortly.

@vividn
Copy link
Contributor Author

vividn commented Oct 8, 2020

I notice that this PR doesn't appear when searching for "review:approved" in the PR list. Probably because I marked it ready to review after you already approved it. Would you mind reapproving it?

@vividn vividn requested a review from kamilchm October 8, 2020 19:51
@vividn
Copy link
Contributor Author

vividn commented Oct 21, 2020

Hey @Lassulus, I noticed you were the last committer for qtile. Could you review and merge this? The changes are minimal. Sorry if this is the wrong way to get it merged, but it's been a few weeks, and I'm worried that this PR will drift into backlog-hell.

@Lassulus Lassulus merged commit 46fac2f into NixOS:master Oct 21, 2020
@Lassulus
Copy link
Member

@vividn sure.
I guess its an okay way to get attention. Maybe you can add me to reviewers next time, then I will get notified by github. Stuff could still fall under the rug though :D

@vividn vividn deleted the patch-1 branch October 21, 2020 15:09
@vividn
Copy link
Contributor Author

vividn commented Oct 21, 2020

Thanks!
As far as I could tell, I didn't have permissions to add reviewers. The gear icon wasn't appearing for me--it seems entirely automated by bots.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/qtile-and-widgets/10590/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilchm kamilchm kamilchm approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vividn @kamilchm @Lassulus @nixos-discourse @Janik-Haag