kernel-builder: Work around kernels getting compiled two times #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like this is not a regression from the latest changes to the kernel builder. Testing on top of ffdba8f exhibits the same issue. This change works around the issue by doing it with one invocation of `make`, rather than doing it twice. It has not been figured out at which exact version of the kernel this stops being an issue, and if it is an issue from mainline Linux outright, or something that came from Android-specific modifications. Though it has been verified that for 3.18, both Qualcomm and Mediatek source trees exhibit the same issue. Fixes NixOS#216
|
With With -j12: Though disabling this change is enough to make it pass... + enableCombiningBuildAndInstallQuirk = false;Or the following: + enableParallelBuilding = false;Which makes me think this is a parallelism issue that's being brought forward by doing the build all at once. Previously the second build was done without the |
While it builds twice now, it at least build successfully.
danielfullmer
approved these changes
Oct 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like this is not a regression from the latest changes to the kernel builder. Testing on top of ffdba8f exhibits the same issue.
This change works around the issue by doing it with one invocation of
make, rather than doing it twice.It has not been figured out at which exact version of the kernel this stops being an issue, and if it is an issue from mainline Linux outright, or something that came from Android-specific modifications.
Though it has been verified that for 3.18, both Qualcomm and Mediatek source trees exhibit the same issue.
Fixes #216
TODO: