Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acme: 120 -> unstable-2020-12-27 #98011

Merged

Conversation

OPNA2608
Copy link
Contributor

Motivation for this change

Changed the version to the unstable scheme, since SVN revisions prolly don't count as releases. Otherwise regular version bump.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

Result of nixpkgs-review 1

2 packages built:
- acme
- cheesecutter
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/development/compilers/acme/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/acme/default.nix Outdated Show resolved Hide resolved
@OPNA2608 OPNA2608 force-pushed the update-acme-unstable-2020-08-26 branch from a025335 to e0b02ce Compare January 18, 2021 13:48
@OPNA2608 OPNA2608 changed the title acme: 120 -> unstable-2020-08-26 acme: 120 -> unstable-2020-12-27 Jan 18, 2021
@OPNA2608
Copy link
Contributor Author

Bumped to latest revision.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 98011 run on x86_64-linux 1

2 packages built:
  • acme
  • cheesecutter

@SuperSandro2000 SuperSandro2000 merged commit 82feb02 into NixOS:master Jan 18, 2021
@OPNA2608 OPNA2608 deleted the update-acme-unstable-2020-08-26 branch September 27, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants