Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hledger, hledger-lib, hledger-ui, and hledger-web: v1.19 -> v1.19.1 #98019

Merged
merged 2 commits into from Sep 15, 2020
Merged

hledger, hledger-lib, hledger-ui, and hledger-web: v1.19 -> v1.19.1 #98019

merged 2 commits into from Sep 15, 2020

Conversation

charukiewicz
Copy link

Motivation for this change

Backporting version bumps of hledger, hledger-lib, hledger-ui, and hledger-web from v1.19 to v1.19.1 from the master branch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@charukiewicz charukiewicz changed the title Version bumps of hledger, hledger-lib, hledger-ui, and hledger-web from v1.19 to v1.19.1 Version bumps of hledger, hledger-lib, hledger-ui, and hledger-web (v1.19 -> v1.19.1) Sep 15, 2020
@charukiewicz charukiewicz changed the title Version bumps of hledger, hledger-lib, hledger-ui, and hledger-web (v1.19 -> v1.19.1) hledger, hledger-lib, hledger-ui, and hledger-web: v1.19 -> v1.19.1 Sep 15, 2020
@cdepillabout
Copy link
Member

Looks good, tests pass.

Thanks @charukiewicz!

cc @peti about this since he is the hledger maintainer here in nixpkgs.

@cdepillabout cdepillabout merged commit 7c27289 into NixOS:release-20.09 Sep 15, 2020
@charukiewicz charukiewicz deleted the release-20.09 branch September 16, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout cdepillabout is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@charukiewicz @cdepillabout @Janik-Haag