Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amdvlk: 2020.Q3.4 -> 2020.Q3.5 and add 32-bit build #97976

Merged
merged 3 commits into from Sep 14, 2020
Merged

amdvlk: 2020.Q3.4 -> 2020.Q3.5 and add 32-bit build #97976

merged 3 commits into from Sep 14, 2020

Conversation

Flakebi
Copy link
Member

@Flakebi Flakebi commented Sep 14, 2020 •
edited

Motivation for this change

AMDVLK 2020.Q3.5 was released: https://github.com/GPUOpen-Drivers/AMDVLK/releases/tag/v-2020.Q3.5
I took the opportunity to include 32-bit support (fixes #93027).

Things done
  • Tested with vkcube and Dota 2
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

danieldk
danieldk suggested changes Sep 14, 2020
View reviewed changes
nixos/doc/manual/configuration/gpu-accel.xml Outdated Show resolved Hide resolved
pkgs/development/libraries/amdvlk/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/amdvlk/default.nix Outdated Show resolved Hide resolved
@danieldk
Copy link
Contributor

Nice to have a 32-bit build as well!

@ofborg ofborg bot requested a review from danieldk September 14, 2020 12:59
@Flakebi
Copy link
Member Author

Flakebi commented Sep 14, 2020

Thanks for your comments, looks a lot cleaner!

danieldk
danieldk suggested changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. Looks good now, only some small nitpicks about the manual changes.

nixos/doc/manual/configuration/gpu-accel.xml Outdated Show resolved Hide resolved
nixos/doc/manual/configuration/gpu-accel.xml Show resolved Hide resolved
nixos/doc/manual/configuration/gpu-accel.xml Outdated Show resolved Hide resolved
nixos/doc/manual/configuration/gpu-accel.xml Outdated Show resolved Hide resolved
danieldk
danieldk approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

Result of nixpkgs-review pr 97976 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
2 packages built:
  • amdvlk
  • driversi686Linux.amdvlk

Will merge once ofborg is also happy.

@ofborg ofborg bot requested a review from danieldk September 14, 2020 15:51
@danieldk danieldk merged commit 04e9c9b into NixOS:master Sep 14, 2020
@Flakebi Flakebi deleted the amdvlk branch September 14, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk Awaiting requested review from danieldk

Assignees
No one assigned
Labels
6.topic: nixos 8.has: documentation 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

amdvlk 32bit
2 participants
@Flakebi @danieldk