Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.graphql_ppx: 0.7.1 -> 1.0.1 #97977

Merged
merged 1 commit into from Sep 14, 2020
Merged

ocamlPackages.graphql_ppx: 0.7.1 -> 1.0.1 #97977

merged 1 commit into from Sep 14, 2020

Conversation

Zimmi48
Copy link
Member

@Zimmi48 Zimmi48 commented Sep 14, 2020

Motivation for this change

New major version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Zimmi48 Zimmi48 requested a review from vbgl September 14, 2020 13:53
@vbgl
Copy link
Contributor

vbgl commented Sep 14, 2020

@GrahamcOfBorg build ocamlPackages.graphql_ppx

@vbgl vbgl merged commit 1074c0a into NixOS:master Sep 14, 2020
@Zimmi48
Copy link
Member Author

Zimmi48 commented Sep 14, 2020

Thanks!

@Zimmi48 Zimmi48 deleted the graphql_ppx-1.0.1 branch September 14, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl Awaiting requested review from vbgl

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zimmi48 @vbgl