Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deno: 1.3.3 -> 1.4.0 -> 1.5.0 #97975

Merged
merged 3 commits into from Oct 28, 2020
Merged

deno: 1.3.3 -> 1.4.0 -> 1.5.0 #97975

merged 3 commits into from Oct 28, 2020

Conversation

06kellyjac
Copy link
Member

@06kellyjac 06kellyjac commented Sep 14, 2020 •
edited

Motivation for this change

Bump deno to 1.4.0 1.5.0
Removed test plugin lib and test server bin

Depends on #96890
Will undraft and rebase once it's merged now in master

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (x86_64)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@06kellyjac 06kellyjac marked this pull request as draft September 14, 2020 12:35
@06kellyjac 06kellyjac changed the title Deno 1.4.0 deno 1.3.3 -> 1.4.0 Sep 15, 2020
@06kellyjac
Copy link
Member Author

06kellyjac commented Sep 23, 2020 •
edited

rust 1.46 now merged. Going to rebase
Edit: actually waiting for staging -> master

@solson
Copy link
Member

solson commented Oct 3, 2020

Deno has moved up to version 1.4.4.

@06kellyjac
Copy link
Member Author

Thanks, I'm aware. Just no real reason to keep bumping versions until rust 1.46 is in master.

If there are people who have a 1.46 overlay or something and want me to keep this PR up to date to actually use deno 1.4.x before it's merged then I can.

@solson
Copy link
Member

solson commented Oct 3, 2020

Ahh, that makes sense. I don't personally need that, I just misunderstood what state this PR was in.

@06kellyjac
Copy link
Member Author

06kellyjac commented Oct 3, 2020 •
edited

No worries, thanks for taking interest.
I'm checking pretty much every day as to whether it's made it from staging to master but I doubt it'll move over until 20.09 is released.

Update: Still waiting for rust 1.46 to make master

@06kellyjac 06kellyjac marked this pull request as ready for review October 27, 2020 20:02
@06kellyjac 06kellyjac changed the title deno 1.3.3 -> 1.4.0 deno: 1.3.3 -> 1.4.0 -> 1.5.0 Oct 27, 2020
@06kellyjac
Copy link
Member Author

Result of nixpkgs-review pr 97975 1

1 package built:
  • deno

1 similar comment
@Mic92
Copy link
Member

Mic92 commented Oct 28, 2020

Result of nixpkgs-review pr 97975 1

1 package built:
  • deno

@Mic92 Mic92 merged commit c5ef62d into NixOS:master Oct 28, 2020
@06kellyjac 06kellyjac deleted the deno_1.4.0 branch October 28, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@06kellyjac @solson @Mic92