Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] python27Packages.anytree: fix build #97982

Closed
wants to merge 1 commit into from
Closed

[20.09] python27Packages.anytree: fix build #97982

wants to merge 1 commit into from

Conversation

drewrisinger
Copy link
Contributor

Motivation for this change

Backport of #97847 to release-20.09. NOTE: the original PR went to staging, not sure if this one should target staging-20.09 as well

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vcunat @drewrisinger
Re-revert "Merge NixOS#97847 python27Packages.anytree: fix build"
9cf79ed 
Moved to staging.
This reverts commit 97e2ca3.

(cherry picked from commit 6705f79)
@vcunat
Copy link
Member

vcunat commented Sep 14, 2020

I took care of that during the move to staging: 195daf8.

I'm trying to always ping the original PRs, but it's easy to miss if you don't know where to look.

@vcunat vcunat closed this Sep 14, 2020
@drewrisinger drewrisinger deleted the zhf/python-anytree-20.09 branch September 14, 2020 16:33
@drewrisinger
Copy link
Contributor Author

Ah, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer jonringer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drewrisinger @vcunat