New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnome-passwordsafe: init at 3.99.2 #98044
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/trouble-building-passwordsafe-a-meson-python-gtk3-package/4652/17 |
Wow cool thanks for packaging! Works good for me so far. Building only fails locally because of unknown license |
pkgs/top-level/all-packages.nix
Outdated
@@ -1124,6 +1124,8 @@ in | |||
|
|||
passExtensions = recurseIntoAttrs pass.extensions; | |||
|
|||
passwordsafe = callPackage ../applications/misc/passwordsafe { }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should be gnome-passwordsafe since that is what you called it. Looks like there is something else called passwordsafe too: https://repology.org/projects/?search=passwordsafe
passwordsafe = callPackage ../applications/misc/passwordsafe { }; | |
gnome-passwordsafe = callPackage ../applications/misc/gnome-passwordsafe { }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I was wondering also if it should not go in gnome3.passwordsafe? I am not sure what goes into deciding that. Should I ping a gnome maintainer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, a gnome maintainer found this 😁 In the case of any gtk application pinging a gnome maintainer is necessary because gtk packaging can be confusing. We're on the fence with there being gnome3.*
at all, so I'd gnome-passwordsafe
would be the best attribute for nixpkgs cc @jtojnar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On another topic, the organization of applications/misc
isn't optimal. I believe this would be a good chance to add a new directory applications/password-managers
. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found this here, but maybe tools isn't a good directory either? pkgs/tools/security/1password-gui/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also: pkgs/tools/security/gnome-keysign
|
||
python3.pkgs.buildPythonApplication rec { | ||
pname = "passwordsafe"; | ||
version = "3.99.2"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.99.2 is a pre-release/dev version, we have a policy of packaging the latest stable release, or currently 3.32.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that in latest version there's support implemented for newer versions of pykeepass
3.99.1
* Updated to pykeepass 3.2
3.99
* Implemented compatibility for pykeepass 3.1
It does appear this is a pre-release from looking at other releases (they follow the standard gnome owned pattern). But I'm confused by the implications from the version this will ship in 4.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also broken for nix in the 3.32.0 release, we would have to patch it, not sure if that has any bearing
https://gitlab.gnome.org/World/PasswordSafe/-/blob/3.32.0/meson.build#L31-40
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could apply https://gitlab.gnome.org/World/PasswordSafe/-/commit/73b7aef155ce9ba597ebcadfb4345cbc966565e7 but if the pre-release version works, it might be more convenient to just use that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 3 other commits to that file after the 3.22.0 tag, so it cant be applied trivially, but anyways I tried with this patch, and it builds, but when I try to open a db it freezes and I have to kill -9 it
https://github.com/mvnetbiz/nixpkgs/blob/gnome-passwordsafe-3-22/pkgs/applications/misc/gnome-passwordsafe/meson.build.patch
65fc862
to
eb87ab2
Compare
It seems you've done the opposite of #98044 (comment) suggestion.
|
eb87ab2
to
deb4c7e
Compare
I think it is less confusing to review if I push fixes and suggested changes individually, and then squash and force-push once someone is ready to commit it, is that a good assumption? This is the most in-depth I've used github... Thanks for being so helpful. 👍 |
Using this package already for a while, works really well. Thank you for your work! |
Result of Works fine for me |
If you could squash it into one commit I can merge 👍 I think this has been good for awhile |
4d8b6b1
to
2cebafe
Compare
Squashed. |
Motivation for this change
Wanted application to replace keepass
other interest in this application: https://discourse.nixos.org/t/trouble-building-passwordsafe-a-meson-python-gtk3-package/4652
Things done
Added gnome-passwordsafe 3.99.2 application
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)