Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=215829 #25536

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gsnedders
Copy link
Member

@jgraham
Copy link
Contributor

jgraham commented Sep 16, 2020

I'm mildly worried about printing error-level logging for things that might not be errors. In particular if you have a test that needs a 404 response, putting an error message in the log isn't that helpful. It may also cause problems in Gecko's CI where we try to parse out the actionable lines from the log; people get annoyed if that summary contains a lot of noise unrelated to actual failures.

I'd suggest maybe logging messages from 500 status at error level and picking a lower level like info for non-500 errors.

@stephenmcgruer
Copy link
Contributor

FYI: wpt-pr-bot didn't pick this up as a WebKit export because (I believe) the WebKit side doesn't have a See Also. So it won't auto-approve or auto-merge this even after the WebKit side is R+ or CQ+

@Hexcles
Copy link
Member

Hexcles commented Sep 16, 2020

+1 to @jgraham usually a web server doesn't log 404 as errors (this is the default in Apache and Nginx, as well as the current behaviour of wptserve for other handlers); the other changes look good.

@gsnedders
Copy link
Member Author

Also this is linked to the wrong WebKit issue; should be https://bugs.webkit.org/show_bug.cgi?id=215829 / https://trac.webkit.org/changeset/266816/webkit

@wpt-pr-bot wpt-pr-bot requested a review from foolip March 26, 2021 14:26
@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@nt1m nt1m changed the title WebKit export of https://bugs.webkit.org/show_bug.cgi?id=215610 WebKit export of https://bugs.webkit.org/show_bug.cgi?id=215829 Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants