[Document Policy] Isolate font-display wpt tests #25518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 14, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2405916
branch
2 times, most recently
from
437c3a5
to
f65e1ba
Compare
This CL splits font-display tests into smaller individual tests. The split has following benefits: - Clear obstable for implementation of violation report deduplication - Make the tests stricter. Before the test can verify there are 4 violation reports generated, but cannot tell which 4 cases generate violation reports. Previously there was an attempt on isolating tests into subframes (https://chromium-review.googlesource.com/c/chromium/src/+/2227863), but failed due to flaky crash in network cache (crbug.com/1087277). Bug: 1087277 Change-Id: Ifad35b40d112956fb00fd680b329e539a8762ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405916 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#807589}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2405916
branch
from
f65e1ba
to
2bc278b
Compare
|
The flaky test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL splits font-display tests into smaller individual tests. The
split has following benefits:
4 violation reports generated, but cannot tell which 4 cases generate
violation reports.
Previously there was an attempt on isolating tests into subframes
(https://chromium-review.googlesource.com/c/chromium/src/+/2227863),
but failed due to flaky crash in network cache (crbug.com/1087277).
Bug: 1087277
Change-Id: Ifad35b40d112956fb00fd680b329e539a8762ed9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405916
Commit-Queue: Charlie Hu <chenleihu@google.com>
Reviewed-by: Jason Chase <chasej@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807589}