Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bash-completion: disable tests #97987

Closed
wants to merge 1 commit into from
Closed

bash-completion: disable tests #97987

wants to merge 1 commit into from

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Sep 14, 2020

Unfortunately, they're very flaky. Let's disable them for now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
bash-completion: disable tests
643c68b 
Unfortunately, they're very flaky. Let's disable them for now.
@flokli flokli mentioned this pull request Sep 14, 2020
Merged
10 tasks
@flokli
Copy link
Contributor Author

flokli commented Sep 14, 2020

This could probably be backported to 20.09 (and 20.03?) as well.

picnoir
picnoir approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@picnoir picnoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this test is currently too flaky to be useful IMHO.

@flokli
Copy link
Contributor Author

flokli commented Sep 14, 2020

I didn't expect this to be a mass rebuild. I cherry-picked this manually into staging as 3bfdbea to avoid the mass-highlight when changing base of this PR.

@flokli flokli closed this Sep 14, 2020
@flokli flokli deleted the bash-completion-disable-tests branch September 14, 2020 21:08
@flokli
Copy link
Contributor Author

flokli commented Sep 14, 2020

Cherry-picked into 20.09-staging as d242782.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnoir picnoir picnoir approved these changes

@marsam marsam Awaiting requested review from marsam

@arianvp arianvp Awaiting requested review from arianvp

@andir andir Awaiting requested review from andir

@peti peti Awaiting requested review from peti

@KamilaBorowska KamilaBorowska Awaiting requested review from KamilaBorowska

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @picnoir