Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgp: 1.7.0.29 -> 1.8 #97983

Merged
merged 1 commit into from Sep 14, 2020
Merged

rgp: 1.7.0.29 -> 1.8 #97983

merged 1 commit into from Sep 14, 2020

Conversation

Flakebi
Copy link
Member

@Flakebi Flakebi commented Sep 14, 2020

Motivation for this change

RGP 1.8 was released: https://github.com/GPUOpen-Tools/radeon_gpu_profiler/releases/tag/v1.8
Today seems to be release day :)

Things done

Tested capturing and viewing a profile of vkcube.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One requested change.

pkgs/development/tools/rgp/default.nix Outdated Show resolved Hide resolved
@danieldk danieldk merged commit 0023908 into NixOS:master Sep 14, 2020
@Flakebi Flakebi deleted the rgp branch September 14, 2020 20:16
@Flakebi
Copy link
Member Author

Flakebi commented Sep 14, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants