Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build-erlang-mk: add support for buildFlags, preserve buildInputs #97984

Merged
merged 2 commits into from Nov 24, 2020
Merged

build-erlang-mk: add support for buildFlags, preserve buildInputs #97984

merged 2 commits into from Nov 24, 2020

Conversation

berbiche
Copy link
Member

@berbiche berbiche commented Sep 14, 2020 •
edited

Motivation for this change

buildErlangMk should use buildFlags/makeFlags as all other make-based functions support.
The function also failed to use the user's buildInputs.

The first commit fixes buildFlags usage, I'm not sure whether configureFlags is also relevant.
The second commit fixes not using the passed-in buildInputs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@berbiche berbiche changed the title build-erlang-mk: add support for buildFlags build-erlang-mk: add support for buildFlags, preserve buildInputs Sep 15, 2020
@berbiche
Copy link
Member Author

The second commit makes buildErlangMk preserve the passed-in buildInputs.

@berbiche
Copy link
Member Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Oct 28, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

vikanezrimaya
vikanezrimaya reviewed Nov 14, 2020
View reviewed changes
Copy link
Member

@vikanezrimaya vikanezrimaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @ericbmerritt as the creator of this file - I don't think I'm able to review this without knowing what Erlang even is 😆

@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 17, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

1 similar comment
@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 20, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

@vikanezrimaya
Copy link
Member

/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 21, 2020

@glittershark please review.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/380

glittershark
glittershark approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@glittershark glittershark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, given the relatively little I know about non-mix erlang stuff

@glittershark
Copy link
Member

/status needs_merger

@marvin-mk2 marvin-mk2 bot requested a review from timokau November 24, 2020 21:37
timokau
timokau approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timokau timokau merged commit b3e4d34 into NixOS:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@vikanezrimaya vikanezrimaya vikanezrimaya left review comments

@glittershark glittershark glittershark approved these changes

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
6.topic: erlang 10.rebuild-darwin: 0 10.rebuild-linux: 0 awaiting_merger marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@berbiche @vikanezrimaya @nixos-discourse @glittershark @timokau @SuperSandro2000