Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python36Packages.ipython: 7.17 -> 7.16.1 (downgrade on Python 3.6 for compatibility) #98024

Merged
merged 1 commit into from Sep 16, 2020
Merged

python36Packages.ipython: 7.17 -> 7.16.1 (downgrade on Python 3.6 for compatibility) #98024

merged 1 commit into from Sep 16, 2020

Conversation

kini
Copy link
Member

@kini kini commented Sep 15, 2020

Motivation for this change

IPython 7.17 and higher don't support Python 3.6 anymore.

nix-repl> :b python36.withPackages (ps: [ ps.ipython ])
builder for '/nix/store/q8v4f89xwv35a3idb9z345z6n3nzfycb-python3.6-ipython-7.17.0.drv' failed with exit code 1; last 10 log lines:
  Python 3.5 was supported with IPython 7.0 to 7.9.
  Python 3.6 was supported with IPython up to 7.16.

  See IPython `README.rst` file for more information:

      https://github.com/ipython/ipython/blob/master/README.rst

  Python sys.version_info(major=3, minor=6, micro=12, releaselevel='final', serial=0) detected.
cannot build derivation '/nix/store/mhpdarp18z6skzswrl7sbgzv8hr4gwih-python3-3.6.12-env.drv': 1 dependencies couldn't be built
[0 built (1 failed)]
error: build of '/nix/store/mhpdarp18z6skzswrl7sbgzv8hr4gwih-python3-3.6.12-env.drv' failed
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Sep 15, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To comply with CONTRIBUTING.md please have the commit message name be of the format

<pkg-name>: <subject-line>

for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

in your case, the commit message should be:

python36Packages: disable

cc @FRidh

@kini kini force-pushed the ipython/disable-on-python36 branch from facb696 to f746462 Compare September 15, 2020 06:30
@kini
Copy link
Member Author

kini commented Sep 15, 2020

Argh, sorry about that. I've now changed the commit message to

python36Packages.ipython: python36 not supported

to match your commit ec1dc42 from last year.

@FRidh
Copy link
Member

FRidh commented Sep 15, 2020

Thanks. We should probably duplicate the expression for 7.16 for Python 3.6.

@kini
Copy link
Member Author

kini commented Sep 15, 2020

Makes sense. Should we also have IPython 7.9 for compatibility with Python 3.5? It looks like we never actually had IPython 7.9, since we jumped from 7.8 to 7.10 in 1f7ee3e.

@FRidh
Copy link
Member

FRidh commented Sep 15, 2020 •
edited

3.5 has been dropped from Nixpkgs because its EOL soon

@kini
python36Packages.ipython: 7.17 -> 7.16.1 (downgrade)
c3618b0 
IPython versions 7.17 and higher don't support Python 3.6 anymore, so
this commit adds back the old expression for 7.16.1 from before
ba1038a for use in python36Packages
only.

    nix-repl> :b python36.withPackages (ps: [ ps.ipython ])
    builder for '/nix/store/q8v4f89xwv35a3idb9z345z6n3nzfycb-python3.6-ipython-7.17.0.drv' failed with exit code 1; last 10 log lines:
      Python 3.5 was supported with IPython 7.0 to 7.9.
      Python 3.6 was supported with IPython up to 7.16.

      See IPython `README.rst` file for more information:

          https://github.com/ipython/ipython/blob/master/README.rst

      Python sys.version_info(major=3, minor=6, micro=12, releaselevel='final', serial=0) detected.
    cannot build derivation '/nix/store/mhpdarp18z6skzswrl7sbgzv8hr4gwih-python3-3.6.12-env.drv': 1 dependencies couldn't be built
    [0 built (1 failed)]
    error: build of '/nix/store/mhpdarp18z6skzswrl7sbgzv8hr4gwih-python3-3.6.12-env.drv' failed
@kini kini force-pushed the ipython/disable-on-python36 branch from f746462 to c3618b0 Compare September 15, 2020 07:18
@kini
Copy link
Member Author

kini commented Sep 15, 2020

Ah, I didn't notice that, thanks. (I still see isPy35 defined in pkgs/top-level/python-packages.nix and used in various places, but I guess it's just always false then.)

I've added a duplicate expression for 7.16 and plugged it into python36Packages, and changed the commit message accordingly.

@kini kini changed the title Disable ipython on Python 3.6 python36Packages.ipython: 7.17 -> 7.16.1 (downgrade on Python 3.6 for compatibility) Sep 15, 2020
@FRidh FRidh merged commit eabba0d into NixOS:master Sep 16, 2020
@kini kini deleted the ipython/disable-on-python36 branch September 16, 2020 07:28
@kini kini mentioned this pull request Nov 25, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@drewrisinger drewrisinger drewrisinger left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kini @FRidh @jonringer @drewrisinger