[css-flex] Slight refactor to how table flex items are handled #25529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 15, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2410596
branch
2 times, most recently
from
5135a73
to
5a3a2e3
Compare
* Don't make all tables in row flexboxes go through the min-width:auto path, which was added in https://chromium-review.googlesource.com/c/chromium/src/+/2392444 * Always make flex item's min/max widths encompass table's min intrinsic size, even if the table has a definite min-width. No behavior change intended. Change-Id: I92456b5c4e20272887066593d166809e6b98ab54 Bug: 1123100,1128262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410596 Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#807492}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2410596
branch
from
5a3a2e3
to
2f7f818
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
path, which was added in
https://chromium-review.googlesource.com/c/chromium/src/+/2392444
intrinsic size, even if the table has a definite min-width.
No behavior change intended.
Change-Id: I92456b5c4e20272887066593d166809e6b98ab54
Bug: 1123100,1128262
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410596
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807492}