Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.scikit-optimize: 0.6 -> 0.8.1 #97990

Merged
merged 1 commit into from Sep 20, 2020
Merged

python.pkgs.scikit-optimize: 0.6 -> 0.8.1 #97990

merged 1 commit into from Sep 20, 2020

Conversation

knedlsepp
Copy link
Member

Motivation for this change

This fixes the build of scikit-optimize.
ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from costrouc September 14, 2020 20:51
drewrisinger
drewrisinger suggested changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't fully fix the build of scikit-optimize, because it still tries to build python27Packages.scikit-optimize. If python27Packages.joblib is disabled like disabled = pythonOlder "3.6";, then that will fully fix the build.

https://github.com/joblib/joblib/blob/19db4f58ac502a4bd01ab07aa31b2fc8756bcc3a/setup.py#L56

@risicle
Copy link
Contributor

risicle commented Sep 14, 2020

(apart from the python 2.7 version) WFM macos 10.14

jonringer
jonringer reviewed Sep 15, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a version of joblib which isn't compatible for python2

pkgs/development/python-modules/scikit-optimize/default.nix Show resolved Hide resolved
@knedlsepp
python.pkgs.scikit-optimize: 0.6 -> 0.8.1
400a63e 
This fixes the build of scikit-optimize.
@drewrisinger
Copy link
Contributor

I think that python2Packages.joblib should still be disabled manually, b/c upstream explicitly doesn't support Python 2. Can also be another PR though.

@knedlsepp
Copy link
Member Author

I think that python2Packages.joblib should still be disabled manually, b/c upstream explicitly doesn't support Python 2. Can also be another PR though.

Moved that to #98046.

jonringer
jonringer approved these changes Sep 20, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/97990
1 package failed to build:
python37Packages.optuna

2 packages built:
python37Packages.scikit-optimize python38Packages.scikit-optimize

@jonringer jonringer merged commit b8f130e into NixOS:master Sep 20, 2020
This was referenced Oct 5, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle left review comments

@drewrisinger drewrisinger drewrisinger requested changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@knedlsepp @risicle @drewrisinger @jonringer