Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redo-sh: 2.0.3 → 4.0.3 #98034

Merged
merged 1 commit into from Sep 15, 2020
Merged

redo-sh: 2.0.3 → 4.0.3 #98034

merged 1 commit into from Sep 15, 2020

Conversation

sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Sep 15, 2020 •
edited

Additional changes:

  • Change platforms from linux to unix. redo-sh should run as long as
    stdenv.shell is a bourne shell. I don't think we can extend portability to
    all, since this also includes stuff like js-ghcjs (not sure we have a
    javascript bourne shell already…)
  • Explicitly pass coreutils as a dependency so it can be overriden to
    use, say busybox.
Motivation for this change

Bug fixes, now correctly checks parent directories.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
redo-sh: 2.0.3 → 4.0.3
4a56eff 
Additional changes:

* Change platforms from linux to unix. redo-sh should run as long as
  stdenv.shell is a bourne shell.
* Explicitly pass coreutils as a dependency so it can be overriden to
  use, say busybox.
@ryantm
Copy link
Member

ryantm commented Sep 15, 2020

Result of nixpkgs-review pr 98034 1

1 package built:
- redo-sh

@ryantm ryantm merged commit 2b3a955 into NixOS:master Sep 15, 2020
@sternenseemann sternenseemann deleted the redo-sh-4.0.3 branch September 15, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sternenseemann @ryantm