GnomeExtensions.Switcher: init at master #98038
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
the
6.topic: GNOME
SuperSandro2000
requested changes
Jan 18, 2021
| @@ -9712,6 +9712,12 @@ | |||
| fingerprint = "F1C5 760E 45B9 9A44 72E9 6BFB D65C 9AFB 4C22 4DA3"; | |||
| }]; | |||
| }; | |||
| chickensoupwithrice = { | |||
There was a problem hiding this comment.
Please put this into a separate commit with the message maintainers: add chickensoupwithrice.
| @@ -1,65 +0,0 @@ | |||
| { stdenv, fetchFromGitHub, fetchurl, xmlstarlet, makeWrapper, ant, jdk, rsync, javaPackages, libXxf86vm, gsettings-desktop-schemas }: | |||
| runHook postInstall | ||
| ''; | ||
|
|
||
| meta = with stdenv.lib; { |
There was a problem hiding this comment.
Suggested change
| meta = with stdenv.lib; { | |
| meta = with lib; { |
| src = fetchFromGitHub { | ||
| owner = "daniellandau"; | ||
| repo = "switcher"; | ||
| rev = "${version}"; |
|
|
||
| stdenv.mkDerivation rec { | ||
| pname = "gnome-shell-switcher"; | ||
| version = "master"; |
There was a problem hiding this comment.
Version number should be unstable-XXX-XX-XX. The X's are the date of the commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Include Switcher Gnome Extension in nixpkgs
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)