Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mbtileserver: init at 0.6.1 #98032

Merged
merged 1 commit into from Sep 16, 2020
Merged

mbtileserver: init at 0.6.1 #98032

merged 1 commit into from Sep 16, 2020

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Sep 15, 2020 •
edited

Motivation for this change

mbtileserver - lightweight and performant server (Go-based) for map tiles stored in MBTiles format.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit September 15, 2020 07:39
@stigtsp
Copy link
Member

stigtsp commented Sep 16, 2020 •
edited

Tested OK against world_cities and geography-class-png test files from https://github.com/consbio/mbtileserver/tree/v0.6.1/mbtiles/testdata

PORT=7777 TILE_DIR=./testdata/ VERBOSE=true mbtileserve
# http://localhost:7777/services/geography-class-png/map

@stigtsp
Copy link
Member

stigtsp commented Sep 16, 2020

@GrahamcOfBorg build mbtileserver

stigtsp
stigtsp approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@stigtsp stigtsp merged commit 2a2cbcb into NixOS:master Sep 16, 2020
@sikmir sikmir deleted the mbtileserver branch September 16, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sikmir @stigtsp