Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awscli2: 2.0.46 -> 2.0.48 #97978

Merged
merged 1 commit into from Sep 15, 2020
Merged

awscli2: 2.0.46 -> 2.0.48 #97978

merged 1 commit into from Sep 15, 2020

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Sep 14, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from bhipple September 14, 2020 13:27
@bhipple
Copy link
Contributor

bhipple commented Sep 15, 2020

Result of nixpkgs-review pr 97978 1

1 package built:
- awscli2

@bhipple bhipple merged commit dc622ed into NixOS:master Sep 15, 2020
@zimbatm zimbatm deleted the awscli2-2.0.48 branch September 15, 2020 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zimbatm @bhipple