Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

akira: 2020-05-01 -> 0.0.13 #98007

Merged
merged 1 commit into from Sep 15, 2020
Merged

akira: 2020-05-01 -> 0.0.13 #98007

merged 1 commit into from Sep 15, 2020

Conversation

neonfuz
Copy link
Contributor

@neonfuz neonfuz commented Sep 14, 2020

Motivation for this change

Version bump 2020-05-01 -> 0.0.13

Upstream started using tagged versions so the package is no longer dated snapshots. I added myself as a maintainer because I intend on following the development of this software and I'm willing to maintain the nix package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace suggested changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message should be

akira: 2020-05-01 -> 0.0.13

See CONTRIBUTING.md and git log

@worldofpeace worldofpeace changed the title akira: version bump 2020-05-01 -> 0.0.13 akira: 2020-05-01 -> 0.0.13 Sep 14, 2020
@worldofpeace
Copy link
Contributor

worldofpeace commented Sep 14, 2020 •
edited

Oops, it should've been akira-unstable. Though, now that I think about it, does that mean this shouldn't be unstable anymore?

@ofborg ofborg bot requested a review from Br1ght0ne September 15, 2020 00:19
@neonfuz
Copy link
Contributor Author

neonfuz commented Sep 15, 2020

I kept unstable because it's still early alpha software, all they did is recently start tagging builds. Does -unstable on nixos just mean an untagged / dated release? If so it should probably be removed, contributing.md doesn't say anything about this but I thought I remember reading somewhere in nix docs what -unstable means

@worldofpeace
Copy link
Contributor

worldofpeace commented Sep 15, 2020 •
edited

I kept unstable because it's still early alpha software, all they did is recently start tagging builds. Does -unstable on nixos just mean an untagged / dated release? If so it should probably be removed, contributing.md doesn't say anything about this but I thought I remember reading somewhere in nix docs what -unstable means

*-unstable packages exists for packages that simultaneously distribute an unstable version with a stable version, or are just strictly alpha software. I can see from the version 0.0.13 (if this is actual semantic version) as a pre-release. So I guess we don't have to change this just yet.

@worldofpeace worldofpeace merged commit 0026c20 into NixOS:master Sep 15, 2020
@worldofpeace
Copy link
Contributor

Thanks @neonfuz ✨

@neonfuz neonfuz deleted the akira branch September 15, 2020 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@neonfuz @worldofpeace