Reland "[blink] Fix top-level-await error reporting" #25530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 15, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2410075
branch
2 times, most recently
from
9b18f41
to
306a5bf
Compare
This is a reland of 077d63da3268e6761d20c56409d37c57d37f1685 Original change's description: > [blink] Fix top-level-await error reporting > > - Enable tests with TLA enabled > - Fix top-level error reporting with TLA > > Based on the discussions on the spec, we fire error events on rejection > of the result promise: > whatwg/html#4352 (comment) > > Bug: 1022182, 1096455, 1127215, v8:9344 > Change-Id: I16e83cb4e279c1e44be7fa70a51a103ee94aacc3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228881 > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Dominic Farolino <dom@chromium.org> > Reviewed-by: Domenic Denicola <domenic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806593} Bug: 1022182 Bug: 1096455 Bug: 1127215 Bug: v8:9344 Bug: 1128296 Change-Id: Icecaccf34efc4354e0faac362da6f6cbdd49f50d
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2410075
branch
from
306a5bf
to
af2d025
Compare
|
Close this PR because the Chromium CL does not have exportable changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reland of 077d63da3268e6761d20c56409d37c57d37f1685
Original change's description:
Bug: 1022182
Bug: 1096455
Bug: 1127215
Bug: v8:9344
Bug: 1128296
Change-Id: Icecaccf34efc4354e0faac362da6f6cbdd49f50d
Reviewed-on: https://chromium-review.googlesource.com/2410075
WPT-Export-Revision: c726631903c0284fdc0088fdb51608dd99c79f9e