[webnfc] Remove id, recordType, and mediaType from NDEFScanOptions. #25523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 14, 2020
Origin Trial feedback was that webNFC is better without filtering. NDEFScanOptions now does not need to carry information like recordType or mediaType as we are not matching them against active watchers anymore. Spec changes: w3c/web-nfc#560 w3c/web-nfc#565 Bug: 520391 Change-Id: I642cff9e72745728f41ad74e803d971a3126ddad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401020 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Cr-Commit-Position: refs/heads/master@{#807597}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2401020
branch
from
4a831ec
to
fcd48db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Origin Trial feedback was that webNFC is better without filtering.
NDEFScanOptions now does not need to carry information like recordType
or mediaType as we are not matching them against active watchers
anymore.
Spec changes:
w3c/web-nfc#560
w3c/web-nfc#565
Bug: 520391
Change-Id: I642cff9e72745728f41ad74e803d971a3126ddad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401020
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com>
Cr-Commit-Position: refs/heads/master@{#807597}