Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli-visualizer: Fix build #97992

Merged
merged 1 commit into from Sep 15, 2020
Merged

Conversation

knedlsepp
Copy link
Member

Motivation for this change

This fixes the cli-visualizer build.
ZHFS: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented Sep 14, 2020

Builds for me, linux x86_64 - but all I can get it to do is show me the help - how am I supposed to use this? Without the -h flag all I get is

Aborted

@knedlsepp
Copy link
Member Author

Builds for me, linux x86_64 - but all I can get it to do is show me the help - how am I supposed to use this?

Hm. I'm running NixOS with plasma and pulseaudio. If I start this it shows a couple of red blocks and works as expected when I play some audio.

@risicle
Copy link
Contributor

risicle commented Sep 14, 2020

I'm on non-nixos linux, with pulseaudio 10.0, perhaps it's too old. Wouldn't worry too much.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
gui launches on linxu

https://github.com/NixOS/nixpkgs/pull/97992
1 package built:
cli-visualizer

@jonringer jonringer merged commit ce065c6 into NixOS:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants