Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 8cdf9c95c453
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 7447bdc5232e
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Sep 14, 2020

  1. nixos/plasma5: Fix eval of colord-kde/wacomtablet 

    Regression introduced by 053b05d.

The commit in question essentially removed the "with pkgs;" from the
scope around the various packages added to environment.systemPackages.

Since services.colord.enable and services.xserver.wacom.enable are false
by default, the change above didn't directly result in an evaluation
error.

Tested evaluation before and after this change via:

  for cfg in hardware.bluetooth.enable \
             networking.networkmanager.enable \
             hardware.pulseaudio.enable \
             powerManagement.enable \
             services.colord.enable \
             services.samba.enable \
             services.xserver.wacom.enable; do
    nix-instantiate --eval nixos --arg configuration '{
      services.xserver.desktopManager.plasma5.enable = true;
      '"$cfg"' = true;
    }' -A config.environment.systemPackages > /dev/null
  done

Signed-off-by: aszlig <aszlig@nix.build>
Cc: @ttuegel
    @aszlig
    aszlig committed Sep 14, 2020
    Copy the full SHA
    7447bdc View commit details
    Browse the repository at this point in the history