Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] softmaker-office: 1018 -> 1020 #98028

Merged
merged 1 commit into from Sep 16, 2020
Merged

[20.09] softmaker-office: 1018 -> 1020 #98028

merged 1 commit into from Sep 16, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Upstream breaks hashes on updates, so we need to backport version updates.

(cherry picked from commit e2c8ae9)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
softmaker-office: 1018 -> 1020
a46fae0 
(cherry picked from commit e2c8ae9)
drewrisinger
drewrisinger approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/98028
1 package built:
softmaker-office

@danieldk
Copy link
Contributor Author

LGTM

https://github.com/NixOS/nixpkgs/pull/98028
1 package built:
softmaker-office

Thanks for the review!

@danieldk danieldk merged commit ee27689 into NixOS:release-20.09 Sep 16, 2020
@danieldk danieldk deleted the softmaker-office-1020-20.09 branch September 16, 2020 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @drewrisinger