Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09]: pythonPackage.python-gitlab: add missing tests requirements #98000

Merged
merged 1 commit into from Sep 15, 2020
Merged

[20.09]: pythonPackage.python-gitlab: add missing tests requirements #98000

merged 1 commit into from Sep 15, 2020

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Sep 14, 2020 •
edited

(cherry picked from commit 9225192)

Motivation for this change

Cherry-picked to fix 20.09 branch

#97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
Copy link
Contributor

Change PR name to [20.09]: ...
Can you also reference the original PR this is cherry-picked from?

@nyanloutre nyanloutre changed the title pythonPackage.python-gitlab: add missing tests requirements [20.09]: pythonPackage.python-gitlab: add missing tests requirements Sep 14, 2020
@nyanloutre
Copy link
Member Author

Original PR: #97866

drewrisinger
drewrisinger approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commit LGTM
  • Builds

x86_64-linux

https://github.com/NixOS/nixpkgs/pull/98000
2 packages built:
python37Packages.python-gitlab python38Packages.python-gitlab

@risicle
Copy link
Contributor

risicle commented Sep 14, 2020 •
edited

WFM macos 10.14

Congrats on getting PR #98000

@nyanloutre
Copy link
Member Author

@risicle what will be the #100000 ?

jonringer
jonringer approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 98000 1

2 packages built:
  • python37Packages.python-gitlab
  • python38Packages.python-gitlab

@jonringer jonringer merged commit a40c69e into NixOS:release-20.09 Sep 15, 2020
@nyanloutre nyanloutre deleted the fix_python_gitlab branch September 15, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@drewrisinger drewrisinger drewrisinger approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nyanloutre @drewrisinger @risicle @jonringer