Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated FASM files get appended to existing ones #1656

Closed
acomodi opened this issue Sep 4, 2020 · 1 comment · Fixed by #1660
Closed

Generated FASM files get appended to existing ones #1656

acomodi opened this issue Sep 4, 2020 · 1 comment · Fixed by #1660

Comments

@acomodi
Copy link
Contributor

acomodi commented Sep 4, 2020

In case build files for a specific test are already present, and another build is performed, the top.merged.fasm, which is used to generate the bitstream, is not overwritten, but instead, the new fasm data of the second build gets appended. This obviously causes FASM collisions when generating the frames.

The problematic lines are the following: https://github.com/SymbiFlow/symbiflow-arch-defs/blob/b3864ae63d668fc7d321b94ca946841e80dd0bb6/common/cmake/devices.cmake#L1058-L1073

Could be solved by removing the arch.merged.fasm file if present, before running the FASM files merge procedure.

@andrewb1999 I believe this was an addition for the partial regions, therefore we have multiple FASM files that need to be collapsed in one only for the bitsream generation step. Do you think the above solution is valid and does not break the partial regions stuff?

@andrewb1999
Copy link
Collaborator

Yes, this change was made for partial regions work. Removing the merged.fasm if it exists should work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants