Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.asyncomplete-vim: init at 2020-08-09 #97128

Merged
merged 1 commit into from Sep 8, 2020

Conversation

vdot0x23
Copy link
Contributor

@vdot0x23 vdot0x23 commented Sep 4, 2020

Motivation for this change

I'd like async completion in pure vim script for vim8 and neovim that can integrate with ALE.

Things done

I'm quite new to nix/nixpkgs and couldn't figure out how to build the expression from the nixpkgs manual.
I'm also a little surprised by ./update.py --add updating other plugins than the one I added, as those probably require testing before updating in case of upstream backwards incompatibilities (but I am not sure how strict nixpkgs is with regards to such things).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

there's a conflict, please rebase on the lastest master

@vdot0x23
Copy link
Contributor Author

vdot0x23 commented Sep 5, 2020

@jonringer, I opted to remove the update commit to avoid conflicts (since I didn't want to resolve manually and rebasing was slow) and now my PR only relates to asyncomplete.vim with no conflicts, hope that is okay :)

@vdot0x23 vdot0x23 reopened this Sep 8, 2020
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 97128 1

1 package built:
  • vimPlugins.asyncomplete-vim

@jonringer jonringer merged commit 2bc02f2 into NixOS:master Sep 8, 2020
@jonringer jonringer mentioned this pull request Sep 14, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants