Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jellyfin: 10.6.3 -> 10.6.4 #97033

Merged
merged 1 commit into from Sep 6, 2020
Merged

jellyfin: 10.6.3 -> 10.6.4 #97033

merged 1 commit into from Sep 6, 2020

Conversation

pstn
Copy link
Contributor

@pstn pstn commented Sep 3, 2020

Motivation for this change

The old sources got depublished again, so please merge asap.

As a more long term solution, I asked the devs to look into not depublishing their sources any more, otherwise we need to either build the combined package ourselves or need to mirror the tarball.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pstn
Copy link
Contributor Author

pstn commented Sep 3, 2020

Scratch that. Their matrix chat helped me find the new scheme. This shouldn't break from now on.

@pstn
Copy link
Contributor Author

pstn commented Sep 4, 2020

Ping maintainers @minijackson @purcell, since the bot didn't, it seems.

Copy link
Member

@minijackson minijackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 97033 1

1 package were built:
  • jellyfin

The nixos test also pass, also passed through the wizard, so it's all good for me!

Thank you for finding out a better URL scheme! That is indeed quite useful

@minijackson
Copy link
Member

The bot probably didn't ping me because I'm not (yet) in ofborg's list, so thanks for the manual ping too ^^

Copy link
Member

@purcell purcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I submitted similar changes to the URL scheme recently in #96221 but withdrew them because they didn't seem strictly necessary at the time.

@purcell
Copy link
Member

purcell commented Sep 4, 2020

The bot probably didn't ping me because I'm not (yet) in ofborg's list, so thanks for the manual ping too ^^

Probably the same for me: I just added myself as a maintainer last week.

@purcell
Copy link
Member

purcell commented Sep 6, 2020

cc @marsam

@marsam marsam merged commit 1c25cb0 into NixOS:master Sep 6, 2020
@purcell
Copy link
Member

purcell commented Sep 6, 2020

Thank you @marsam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants