New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jellyfin: 10.6.3 -> 10.6.4 #97033
jellyfin: 10.6.3 -> 10.6.4 #97033
Conversation
Scratch that. Their matrix chat helped me find the new scheme. This shouldn't break from now on. |
Ping maintainers @minijackson @purcell, since the bot didn't, it seems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of nix-review pr 97033
1
1 package were built:
- jellyfin
The nixos test also pass, also passed through the wizard, so it's all good for me!
Thank you for finding out a better URL scheme! That is indeed quite useful
The bot probably didn't ping me because I'm not (yet) in ofborg's list, so thanks for the manual ping too ^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I submitted similar changes to the URL scheme recently in #96221 but withdrew them because they didn't seem strictly necessary at the time.
Probably the same for me: I just added myself as a maintainer last week. |
cc @marsam |
Thank you @marsam |
Motivation for this change
The old sources got depublished again, so please merge asap.
As a more long term solution, I asked the devs to look into not depublishing their sources any more, otherwise we need to either build the combined package ourselves or need to mirror the tarball.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)