Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radare2: 4.5.0 -> 4.5.1 #97091

Merged
merged 1 commit into from Sep 6, 2020
Merged

radare2: 4.5.0 -> 4.5.1 #97091

merged 1 commit into from Sep 6, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Sep 4, 2020 •
edited

Motivation for this change

fixes CVE-2020-17487, CVE-2020-16269

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This was referenced Sep 4, 2020
Closed
Closed
@ofborg ofborg bot requested review from 7c6f434c and makefu September 4, 2020 08:59
tomberek
tomberek approved these changes Sep 6, 2020
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs on NixOS. Minimal functionality tested.

@7c6f434c 7c6f434c merged commit ccf01af into NixOS:master Sep 6, 2020
@Mic92 Mic92 deleted the radare2 branch September 6, 2020 18:35
@Mic92
Copy link
Member Author

Mic92 commented Sep 6, 2020

20.03 backport: 43a27ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@makefu makefu Awaiting requested review from makefu

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @tomberek @7c6f434c