Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnupg: 2.2.21 -> 2.2.23 [security] #97044

Closed
wants to merge 1 commit into from
Closed

gnupg: 2.2.21 -> 2.2.23 [security] #97044

wants to merge 1 commit into from

Conversation

tokudan
Copy link
Contributor

@tokudan tokudan commented Sep 3, 2020 •
edited

Motivation for this change

fixes critical security issue: https://lists.gnupg.org/pipermail/gnupg-announce/2020q3/000448.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tokudan
Copy link
Contributor Author

tokudan commented Sep 3, 2020

@GrahamcOfBorg build gnupg

@tokudan
Copy link
Contributor Author

tokudan commented Sep 3, 2020

seems to be a similar PR to #97034 but that one has a different source version? not sure what that is about.

@cole-h
Copy link
Member

cole-h commented Sep 3, 2020

Because it's targeted against staging, which is already on 2.2.22.

Given that this would need to be targeted to staging as well, I suggest to close this PR and rally behind the other one.

@ofborg ofborg bot requested review from vrthra, peti and fpletz September 3, 2020 21:21
@FRidh FRidh changed the base branch from master to staging September 4, 2020 18:02
@FRidh FRidh changed the base branch from staging to master September 4, 2020 18:04
@FRidh FRidh changed the base branch from master to staging September 4, 2020 18:04
@cole-h
Copy link
Member

cole-h commented Sep 4, 2020

Superceded by #97034; closing.

@cole-h cole-h closed this Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrthra vrthra Awaiting requested review from vrthra

@peti peti Awaiting requested review from peti

@fpletz fpletz Awaiting requested review from fpletz

@adisbladis adisbladis Awaiting requested review from adisbladis

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tokudan @cole-h