Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 5079e1cd3b30
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 58e585c93b81
Choose a head ref
  • 4 commits
  • 4 files changed
  • 2 contributors

Commits on Sep 4, 2020

  1. vimPlugins: Refactor coc-* plugins and fix coc-go 

    There are 32 vim plugins, all related to the coc.nvim LSP plugin, that
are actually node packages and are included in nodePackages. In #82578,
those vim plugins were made to point at the corresponding node packages,
which fixed issues where the sources weren't being compiled properly
with Javascript build systems.

The way each of those vim plugins wraps its corresponding node package
is identical, so I factored that out into a function and eliminated the
duplication.

In addition, for some reason coc-go got missed, which led to it not
working correctly for me. I included it in my list of packages to wrap,
so that fixes that issue.
    @jonringer
    Jake Waksbaum authored and jonringer committed Sep 4, 2020
    Copy the full SHA
    16592e5 View commit details
    Browse the repository at this point in the history

  2. vimPlugins: Remove coc-* from vim-plugin-names 

    Because these plugins use the node packages as their source, there's no
reason to pull their sources from GitHub only to have it be overriden.

This will trigger the removal of these plugins from generated.nix the
next time update.py is run.
    @jonringer
    Jake Waksbaum authored and jonringer committed Sep 4, 2020
    Copy the full SHA
    8a28f7f View commit details
    Browse the repository at this point in the history

  3. vimPlugins: update

    @jonringer
    Jake Waksbaum authored and jonringer committed Sep 4, 2020
    Copy the full SHA
    b468834 View commit details
    Browse the repository at this point in the history

  4. vimPlugins: Document node-based plugins

    @jbaum98 @jonringer
    jbaum98 authored and jonringer committed Sep 4, 2020
    Copy the full SHA
    58e585c View commit details
    Browse the repository at this point in the history