Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

texi2html: Fix cross-platform build #97093

Merged
merged 1 commit into from Jan 17, 2021
Merged

texi2html: Fix cross-platform build #97093

merged 1 commit into from Jan 17, 2021

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Sep 4, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kampka kampka added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Sep 4, 2020
@kampka
Copy link
Contributor Author

kampka commented Sep 4, 2020

@GrahamcOfBorg build texi2html
@GrahamcOfBorg build pkgsCross.aarch64-multiplatfrom.texi2html

@symphorien
Copy link
Member

maybe you can add strictDeps = true to make regressions less likely?
This applies to many of your cross-fixing PRs.

@kampka
Copy link
Contributor Author

kampka commented Sep 6, 2020

@GrahamcOfBorg build texi2html
@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.texi2html

@kampka
Copy link
Contributor Author

kampka commented Sep 6, 2020

maybe you can add strictDeps = true to make regressions less likely?
This applies to many of your cross-fixing PRs.

Done (other will follow).

@SuperSandro2000
Copy link
Member

Please target master. This is not a mass rebuild.

@kampka
Copy link
Contributor Author

kampka commented Dec 29, 2020

Please target master. This is not a mass rebuild.

@SuperSandro2000 can you please for future reference clarify what constitutes as a mass rebuild and ideally have that documented clearly (as in 'objectively') in the staging branch section of the nixpkgs manual? I have asked that question multiple times and in different spaces and have never gotten a definitive answer. Thanks.

@SuperSandro2000
Copy link
Member

Please target master. This is not a mass rebuild.

@SuperSandro2000 can you please for future reference clarify what constitutes as a mass rebuild and ideally have that documented clearly (as in 'objectively') in the staging branch section of the nixpkgs manual? I have asked that question multiple times and in different spaces and have never gotten a definitive answer. Thanks.

500+ plus is a mass rebuild.

@kampka kampka requested a review from edolstra as a code owner January 12, 2021 20:11
@kampka kampka changed the base branch from staging to master January 12, 2021 20:11
@ofborg ofborg bot requested review from a user, fgaz and MarcWeber January 12, 2021 23:21
@fgaz
Copy link
Member

fgaz commented Jan 13, 2021

Anyone knows why @GrahamcOfBorg requested my review? Maybe some recent history (the mindustry updates in particular, since there's @petabyteboy too) got briefly included while switching branch and force pushing?

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 97093 run on x86_64-darwin 1

4 packages marked as broken and skipped:
  • btrbk
  • frescobaldi
  • lilypond-unstable
  • udiskie
11 packages built:
  • asciidoc-full
  • asciidoc-full-with-plugins
  • ccache
  • ccacheStdenv
  • knightos-genkfs
  • knightos-kimg
  • knightos-mktiupgrade
  • lilypond
  • lilypond-with-fonts
  • rep
  • texi2html

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 97093 run on x86_64-linux 1

2 packages failed to build and are new build failures:
35 packages built:
  • adapta-gtk-theme
  • asciidoc-full
  • asciidoc-full-with-plugins
  • btrbk
  • ccache
  • ccacheStdenv
  • ccacheWrapper
  • chrome-gnome-shell
  • clevis
  • denemo
  • disorderfs
  • frescobaldi
  • gnome3.gnome-session (gnome3.gnome_session)
  • gnome3.gnome-shell (gnome3.gnome_shell)
  • gnome3.gnome-terminal (gnome3.gnome_terminal)
  • gnome3.gnome-tweaks (gnome3.gnome-tweak-tool)
  • gnome3.pomodoro
  • gnomeExtensions.easyScreenCast
  • gnomeExtensions.gsconnect
  • gnomeExtensions.night-theme-switcher
  • herbstluftwm
  • knightos-genkfs
  • knightos-kimg
  • knightos-mkrom
  • knightos-mktiupgrade
  • lilypond
  • lilypond-unstable
  • lilypond-with-fonts
  • luksmeta
  • pantheon.elementary-session-settings
  • rep
  • solfege
  • tang
  • texi2html
  • udiskie

@ghost
Copy link

ghost commented Jan 14, 2021

Anyone knows why @GrahamcOfBorg requested my review? Maybe some recent history (the mindustry updates in particular, since there's @petabyteboy too) got briefly included while switching branch and force pushing?

Yes, one commit that was pushed to the branch, https://github.com/NixOS/nixpkgs/commits/0fd3afc1b2fb053d6b6f67db659b0a236d60cbf8, also contains a mindustry change, but it's not included in the diff anymore.

@symphorien symphorien merged commit 47d1215 into NixOS:master Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@fgaz fgaz Awaiting requested review from fgaz

@MarcWeber MarcWeber Awaiting requested review from MarcWeber

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kampka @symphorien @SuperSandro2000 @fgaz