Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snippetpixie: 1.3.3 -> 1.4.1 #97057

Merged
merged 1 commit into from Sep 4, 2020
Merged

snippetpixie: 1.3.3 -> 1.4.1 #97057

merged 1 commit into from Sep 4, 2020

Conversation

ianmjones
Copy link
Member

Motivation for this change

Update Snippet Pixie to version 1.4.1.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from worldofpeace September 4, 2020 00:07
worldofpeace
worldofpeace approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome and wayland support ✨

@worldofpeace worldofpeace merged commit af189fb into NixOS:master Sep 4, 2020
@worldofpeace
Copy link
Contributor

In future updates, keep in mind it is useful to the reviewer to link the changelogs. In this instance it would be the appdata file https://github.com/bytepixie/snippetpixie/blob/develop/data/com.github.bytepixie.snippetpixie.appdata.xml.in

@ianmjones
Copy link
Member Author

In future updates, keep in mind it is useful to the reviewer to link the changelogs.

👍 No problem, good idea.

@ianmjones ianmjones deleted the fix/snippetpixie-update branch September 4, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ianmjones @worldofpeace