Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildSupport.rust: fix typo in verifyCargoDeps message #97058

Merged
merged 1 commit into from Sep 5, 2020

Conversation

evanjs
Copy link
Member

@evanjs evanjs commented Sep 4, 2020

Fix a minor typo within the verifyCargoDeps message:

"Build the derivation and wait for it to fail with a hash mismatch"

@evanjs
Copy link
Member Author

evanjs commented Sep 4, 2020

.... looks like this should not go to master :D
Staging, then?

@worldofpeace
Copy link
Contributor

@evanjs Um, usually 501+ is a good place for staging. But since these are rust builds, it takes a long time and cpu. So I believe staging could be better.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving until branch is changed

@evanjs evanjs changed the base branch from master to staging September 5, 2020 20:32
@worldofpeace worldofpeace merged commit 19cb34b into NixOS:staging Sep 5, 2020
@worldofpeace
Copy link
Contributor

Thanks @evanjs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants