Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.haskell-language-server: 0.3.0 -> 0.4.0 #97062

Merged
merged 1 commit into from Sep 4, 2020
Merged

haskellPackages.haskell-language-server: 0.3.0 -> 0.4.0 #97062

merged 1 commit into from Sep 4, 2020

Conversation

maralorn
Copy link
Member

@maralorn maralorn commented Sep 4, 2020 •
edited

I am sorry for the override scope shenanigans I am doing there. But

a) this is the best way I could think of to prevent code duplication.
b) haskell-language-server will soon be in hackage and probably even in stack. Then everything will become easier.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cdepillabout
cdepillabout approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Getting these packages in stack will make it a lot easier for us!

@maralorn maralorn merged commit 121527d into NixOS:haskell-updates Sep 4, 2020
@maralorn maralorn deleted the bump-hls branch September 4, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

Assignees
No one assigned
Labels
6.topic: haskell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maralorn @cdepillabout