FYI @Alexey-T

some things don't work like install plugins,

It works, after you configure the "pylib__linux" option
https://wiki.freepascal.org/CudaText#Python_on_Linux.2C_BSD.2C_Solaris

scroll tab left/right buttons,

It works. on your screen, we have little count of tabs so they don't scroll.

It works, after you configure the "pylib__linux" option

Before build, I set full path to libpython3.so in https://github.com/Alexey-T/CudaText/blob/3cbe36fb8aa3ee67262fc6079335259c0589edeb/app/proc_globdata.pas#L976
Am I right that after that it's not needed to specify full path in settings_default?

$ grep "\"pylib__linux\":" result/share/cudatext/settings_default/default.json
  "pylib__linux": "libpython3.so",

Steps to reproduce:

1. Plugins -> Addons Manager -> Install (Nix lexer) - "Package installed", no errors.
2. Open some flake.nix file, dialog "Lexer(s) for flake.nix", choose "Download lexer: Nix", no errors, nothing happens, no highlighting.

It looks like Nix lexer was not actually installed.

I've just found the root cause, CudaText on first start copy data folder from nix store into ~/.config/cudatext/data with 555 permissions, instead of 755.

It works, after you configure the "pylib__linux" option

Before build, I set full path to libpython3.so in https://github.com/Alexey-T/CudaText/blob/3cbe36fb8aa3ee67262fc6079335259c0589edeb/app/proc_globdata.pas#L976
Am I right that after that it's not needed to specify full path in settings_default?

IMO yes, it should work.

$ grep "\"pylib__linux\":" result/share/cudatext/settings_default/default.json
  "pylib__linux": "libpython3.so",

but default.json is not read by program, it's only for user reference.

I've just found the root cause, CudaText on first start copy data folder from nix store into ~/.config/cudatext/data with 555 permissions, instead of 755.

Cud runs this:

  {$ifdef linux}
  if OpDirLocal<>OpDirExe then
    if IsDistroUpdateNeeded then
      if DirectoryExistsUTF8(OpDirPrecopy) then
        RunCommand('cp', ['-R', '-u', '-t',
          OpDirLocal,
          '/usr/share/cudatext/py',
          '/usr/share/cudatext/data',
          '/usr/share/cudatext/settings_default'
          ], S);
  {$endif}  

so permissions 555 is copy from your dir, which is 555.

so permissions 555 is copy from your dir, which is 555.

Indeed, folder in nix store have 555 permissions. IMHO, It would be good if CudaText would make no assumption about source permissions and force 755 while copying. What do you think?

Yes, agree. Will try to change that code part.

Made this change. do you need new linux build?

Made this change.

Thanks!

do you need new linux build?

No, nix package doesn't use binary CudaText packages, but build it from sources. So I can just apply your patch.

Nix lexer is now installed by default, just for convenience of Nix users.

I built it again, but can't see the changes. Plugins still don't appear and Nix is not known.

davidak@gaming:~/code/nixpkgs]$ nix-shell -p nixpkgs-review --run "nixpkgs-review pr 97063"

Check that file Nix.lcf exists in the .config/cudatext/data/lexlib.

Plugins don't appear? But python console panel input works OK? press Ctrl+tilde - input works ok?

I built it again, but can't see the changes. Plugins still don't appear and Nix is not known.

davidak@gaming:~/code/nixpkgs]$ nix-shell -p nixpkgs-review --run "nixpkgs-review pr 97063"

I've not commited yet, wait a bit...

@davidak Check it now, it works for me.

Just note that currrent version is 1.111.0.

Just note that currrent version is 1.111.0.

I don't see 1.111.0 in https://github.com/Alexey-T/CudaText/tags.

Ah, "tag" will be little later, in 1-2 days.

@Alexey-T Just in case, is there any repo where I can find CudaText translations other than https://sourceforge.net/projects/cudatext/files/addons/translations/? I can't find it in https://github.com/CudaText-addons as well. I want to allow users to optionally install more languages by default, like it's done for libreoffice:

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/295

@davidak I've added libqt5pas, so now CudaText can be built with qt5 widgetset as well. And I've switched default widgetset from gtk2 to qt5, it looks a bit better for me.

With the dark theme "sub", the menu text is now black on dark grey.

terminal output:

[nix-shell:~/.cache/nixpkgs-review/pr-97063-7]$ cudatext
QApplication: invalid style override 'adwaita' passed, ignoring it.
	Available styles: Breeze, Windows, Fusion

Hmm, here is my (qt5, there is no errors in terminal):

Maybe it makes sense to switch default option back to gtk2.

I'm using the GTK-based Pantheon desktop.

@davidak Maybe you need to install the Adwaita theme files?

@sikmir do you think this is ready to merge as it is (mention me once you have a follow-up PR with more improvements), or is it better to wait for some soon-to-happen debugging/polishing?

@sikmir do you think this is ready to merge as it is (mention me once you have a follow-up PR with more improvements), or is it better to wait for some soon-to-happen debugging/polishing?

1.111.0 is out meanwhile (fixes problem with permissions, so we can remove patching), so let me to update and I thnk we are ready to proceed.

@7c6f434c Update to 1.111.0 is done and verified, feel free to proceed with merge.