Should there be a setting to toggle the effects of this PR? Not all players may want this change as it may increase the clutter for some.

A setting for this would be the right call, yes, but it can be on by default as far as I am concerned.

You did mangle two patches here, it seems, as I think part of "Feature: Show group name as part of the default vehicle name." is also in here :)

You did mangle two patches here, it seems, as I think part of "Feature: Show group name as part of the default vehicle name." is also in here :)

I fixed my issue by merging your other patch. A rebase solves the problem now :D

Is there somewhere an explanation what this info is used for?

• Usually all vehicles in a group carry the same cargo, unless they use refit orders, right?
• Cloning vehicles copies refitting, so it's also unlikely to introduce inconsistencies?

I would see the usefulness of prepending groups names with the cargos of all member vehicles, but I don't understand why someone would want to see it per vehicle.

Its depend on how someone organizes groups or whether using groups at all. The vehicles can be grouped by engines, by stations they visit, etc. But may be it is useful in the "all group" group. For example if you want to see which trains make the lowest profits, you can also whether the cargo makes them not profitable, so maybe better to carry it by other vehicle types.

But maybe sometimes you just would like to see which vehicle carry what when you just browsing the vehicle list. :)

I admit it may be the 'most' useful in the "all group" group. :)

Edit:
It also shows the cargoes in the station and waypoint lists:

This seems like a useful tool for waypoint and station management, especially with NewGRFs with lots of cargos carried in similar vehicles (looking at you, Iron Horse + FIRS Steeltown).

It needs some padding between the text and the vehicle sprite. Default engines abut the text with no space in between.

Also needs a rebase (hopefully the last one, because I'd like to approve this 😃 )

It needs some padding between the text and the vehicle sprite. Default engines abut the text with no space in between.

Its using the same string as the vehicles' names and also depends on the sprites' offsets. (Give a name to a vehicle, and check it out it in the vehicle list.)

So I would like to leave this to someone else with much more experience with padding, margins, and scaling. :)

@PeterN Any thoughts on the padding issue described above? Apparently this is an existing problem. Will #10114 fix it? 🙂

(Once that's solved, I'd like to approve this.)

Maybe out of the scope of this PR, but I think it'd be really nice if you could put the cargo list dynamically in the name with a string key. For example if you put Train 1 for {CARGO} in the name editor box for a vehicle it would show up everywhere else as "Train 1 for [Iron, Wood]". or maybe don't include the brackets and just make Train 1 for ({CARGO}) show up as "Train 1 for (Iron, Wood)"