Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux_zen: 5.8.1 -> 5.8.7 #97038

Merged
merged 1 commit into from Sep 6, 2020
Merged

linux_zen: 5.8.1 -> 5.8.7 #97038

merged 1 commit into from Sep 6, 2020

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Sep 3, 2020

Motivation for this change

Closes #96933

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Atemu
Copy link
Member Author

Atemu commented Sep 3, 2020

Result of nixpkgs-review 1

35 packages failed to build:
- linuxPackages_zen.amdgpu-pro
- linuxPackages_zen.anbox
- linuxPackages_zen.ati_drivers_x11
- linuxPackages_zen.batman_adv
- linuxPackages_zen.can-isotp
- linuxPackages_zen.chipsec
- linuxPackages_zen.cryptodev
- linuxPackages_zen.ena
- linuxPackages_zen.exfat-nofuse
- linuxPackages_zen.ixgbevf
- linuxPackages_zen.lttng-modules
- linuxPackages_zen.mwprocapture
- linuxPackages_zen.mxu11x0
- linuxPackages_zen.ndiswrapper
- linuxPackages_zen.netatop
- linuxPackages_zen.nvidia_x11_legacy304
- linuxPackages_zen.nvidia_x11_legacy340
- linuxPackages_zen.nvidia_x11_legacy390
- linuxPackages_zen.nvidiabl
- linuxPackages_zen.openafs
- linuxPackages_zen.openafs_1_8
- linuxPackages_zen.phc-intel
- linuxPackages_zen.r8168
- linuxPackages_zen.rtl8723bs
- linuxPackages_zen.rtl8812au
- linuxPackages_zen.rtl8814au
- linuxPackages_zen.rtl8821au
- linuxPackages_zen.rtl8821cu
- linuxPackages_zen.rtl88x2bu
- linuxPackages_zen.rtl88xxau-aircrack
- linuxPackages_zen.rtlwifi_new
- linuxPackages_zen.sch_cake
- linuxPackages_zen.tbs
- linuxPackages_zen.virtualbox
- linuxPackages_zen.virtualboxGuestAdditions
42 packages built:
- linuxPackages_zen.acpi_call
- linuxPackages_zen.asus-wmi-sensors
- linuxPackages_zen.bbswitch
- linuxPackages_zen.bcc
- linuxPackages_zen.bpftrace
- linuxPackages_zen.broadcom_sta
- linuxPackages_zen.cpupower
- linuxPackages_zen.ddcci-driver
- linuxPackages_zen.digimend
- linuxPackages_zen.dpdk
- linuxPackages_zen.evdi
- linuxPackages_zen.facetimehd
- linuxPackages_zen.fwts-efi-runtime
- linuxPackages_zen.hyperv-daemons
- linuxPackages_zen.intel-speed-select
- linuxPackages_zen.it87
- linuxPackages_zen.jool
- linuxPackages_zen.kernel
- linuxPackages_zen.mba6x_bl
- linuxPackages_zen.nvidia_x11
- linuxPackages_zen.oci-seccomp-bpf-hook
- linuxPackages_zen.openrazer
- linuxPackages_zen.perf
- linuxPackages_zen.ply
- linuxPackages_zen.r8125
- linuxPackages_zen.rtl8192eu
- linuxPackages_zen.rtl8821ce
- linuxPackages_zen.sysdig
- linuxPackages_zen.systemtap
- linuxPackages_zen.tmon
- linuxPackages_zen.tp_smapi
- linuxPackages_zen.turbostat
- linuxPackages_zen.tuxedo-keyboard
- linuxPackages_zen.usbip
- linuxPackages_zen.v4l2loopback
- linuxPackages_zen.v86d
- linuxPackages_zen.vhba
- linuxPackages_zen.x86_energy_perf_policy
- linuxPackages_zen.xpadneo
- linuxPackages_zen.zenpower
- linuxPackages_zen.zfs
- linuxPackages_zen.zfsUnstable

@Atemu Atemu changed the title linux_zen: 5.8.1 -> 5.8.6 linux_zen: 5.8.1 -> 5.8.7 Sep 5, 2020
@7c6f434c
Copy link
Member

7c6f434c commented Sep 6, 2020

If you have a build setup where review builds make sense, could you check that the failures are already present before the bump?

@Atemu
Copy link
Member Author

Atemu commented Sep 6, 2020

Is there a trivial way of doing that?

The build failures all sound like out-of-tree modules that I wouldn't expect to be compatible with 5.8 yet though. (The popular ones (ZFS and Nvidia) both work however).

Perhaps we should declare which ABIs each module are compatible with so that nobody even attempts to build them for incompatible kernels.

@7c6f434c
Copy link
Member

7c6f434c commented Sep 6, 2020 via email

@Atemu
Copy link
Member Author

Atemu commented Sep 6, 2020

I couldn't get anything decent working ad-hoc but I think most of these were broken before too.

Mic92/nixpkgs-review#85 should cover this use-case though.

Well, you often do not know in advance if the next release will contain breaking API changes for free but out-of-tree modules.

I meant a blocklist that gets amended when a new ABI becomes incompatible. E.g. no longer works on 5.8 -> mark as broken for >=5.8.

Though it seems like many of the packages were already marked as broken. Not sure why nixpkgs-review tried to build them and reported them as failures when they were known to be bad before and after.
cc @Mic92

@7c6f434c 7c6f434c merged commit 2e4f8eb into NixOS:master Sep 6, 2020
@Atemu Atemu deleted the update/linux_zen branch September 6, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants