Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotspot: 1.2.0 -> 1.3.0 #97084

Merged
merged 1 commit into from Sep 4, 2020
Merged

hotspot: 1.2.0 -> 1.3.0 #97084

merged 1 commit into from Sep 4, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Sep 4, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/cwl0dhpjdf6brsq912d2qpfb132qgf73-hotspot-1.2.0 1.3G
/nix/store/p43h4rdcpgg2vky38w6ql8kvn82p1012-hotspot-1.3.0 1.3G

@ofborg ofborg bot requested a review from nh2 September 4, 2020 06:52
@nh2
Copy link
Contributor

nh2 commented Sep 4, 2020

Thanks, GUI is working fine for me.

Changelog at https://github.com/KDAB/hotspot/releases/tag/v1.3.0 looks good.

@nh2 nh2 merged commit 5829744 into NixOS:master Sep 4, 2020
@bbigras bbigras deleted the hotspot branch September 4, 2020 13:42
@bbigras
Copy link
Contributor Author

bbigras commented Sep 4, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2 Awaiting requested review from nh2

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bbigras @nh2