Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsci: init at 7.0.12 #97054

Merged
merged 2 commits into from Sep 6, 2020
Merged

vsci: init at 7.0.12 #97054

merged 2 commits into from Sep 6, 2020

Conversation

dali99
Copy link
Member

@dali99 dali99 commented Sep 3, 2020

Motivation for this change

vsci is a very popular cli video "contact sheet" generator.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dali99
Copy link
Member Author

dali99 commented Sep 4, 2020

@marsam you seem to do a lot of video related PRs

Requesting review ^-^

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/293

pkgs/tools/video/vcsi/default.nix Outdated Show resolved Hide resolved
pkgs/tools/video/vcsi/default.nix Outdated Show resolved Hide resolved
pkgs/tools/video/vcsi/default.nix Outdated Show resolved Hide resolved
pkgs/tools/video/vcsi/default.nix Outdated Show resolved Hide resolved
pkgs/tools/video/vcsi/default.nix Outdated Show resolved Hide resolved
@marsam marsam merged commit 18bfc49 into NixOS:master Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants