Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p3x-onenote: init at 2020.10.111 #97055

Merged
merged 2 commits into from Sep 9, 2020
Merged

p3x-onenote: init at 2020.10.111 #97055

merged 2 commits into from Sep 9, 2020

Conversation

tiagolobocastro
Copy link
Contributor

@tiagolobocastro tiagolobocastro commented Sep 3, 2020 •
edited

Motivation for this change

Add package for p3x-onenote - A Linux compatible version of OneNote

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/add-new-application/8867/8

@tiagolobocastro tiagolobocastro force-pushed the p3x-onenote branch 4 times, most recently from f636ac8 to 0e89afe Compare September 4, 2020 13:04
@tiagolobocastro tiagolobocastro force-pushed the p3x-onenote branch 2 times, most recently from 036ad43 to 60d1066 Compare September 5, 2020 00:11
@Atemu
Copy link
Member

Atemu commented Sep 5, 2020

Result of nixpkgs-review pr 97055 1

1 package built:
- p3x-onenote

WOMM.

Not sure why ofBorg can't eval, might be unrelated.

Small nit: tiagolobocastro#1

@tiagolobocastro
Copy link
Contributor Author

Result of nixpkgs-review pr 97055 1
1 package built:

  • p3x-onenote

WOMM.

Not sure why ofBorg can't eval, might be unrelated.

Small nit: tiagolobocastro#1

Thanks @Atemu, seems like adding the version to the name did the trick 👍

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/add-new-application/8867/9

jonringer
jonringer reviewed Sep 6, 2020
View reviewed changes
pkgs/applications/office/p3x-onenote/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/p3x-onenote/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/applications/office/p3x-onenote/default.nix Outdated Show resolved Hide resolved
@tiagolobocastro tiagolobocastro force-pushed the p3x-onenote branch 2 times, most recently from 57d55d3 to 4bbe6ff Compare September 6, 2020 20:56
jonringer
jonringer reviewed Sep 7, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, appimage tools will use buildFHSUserEnv, and so the autopatch shouldn't be needed

pkgs/applications/office/p3x-onenote/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/p3x-onenote/default.nix Outdated Show resolved Hide resolved
jonringer
jonringer approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
gui launches fine

https://github.com/NixOS/nixpkgs/pull/97055
1 package built:
p3x-onenote

@jonringer jonringer merged commit 4964392 into NixOS:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atemu Atemu Atemu left review comments

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tiagolobocastro @nixos-discourse @Atemu @jonringer